refactor: make kube config optional in nas/oss node drivers #1607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
iltyty
force-pushed
the
optional-kube-config
branch
from
d5f3f21 to
acc41ab
Compare
iltyty
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
huww98
reviewed
Jan 5, 2026
huww98
reviewed
Jan 5, 2026
Contributor
huww98
left a comment
huww98
left a comment
There was a problem hiding this comment.
Maybe we should get configmap once and pass it (or the wrapping utils.Config object) along to different drivers
AlbeeSo
reviewed
Jan 6, 2026
mowangdk
reviewed
Jan 7, 2026
mowangdk
reviewed
Jan 7, 2026
iltyty
force-pushed
the
optional-kube-config
branch
4 times, most recently
from
49cbb11 to
6bfe472
Compare
k8s-ci-robot
added
the
needs-rebase
iltyty
force-pushed
the
optional-kube-config
branch
2 times, most recently
from
c8d6f9e to
0280dc4
Compare
k8s-ci-robot
removed
the
needs-rebase
iltyty
force-pushed
the
optional-kube-config
branch
2 times, most recently
from
f50bea1 to
ad9a61d
Compare
iltyty
changed the title
iltyty
force-pushed
the
optional-kube-config
branch
from
ad9a61d to
439bf6b
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iltyty, mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Make kube config optional on oss and nas node servers, supporting reading relevant configurations from env variables.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: